Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distributed tracing is missing datadog support #593

Closed
christian-roggia opened this issue May 13, 2021 · 4 comments · Fixed by #600
Closed

Distributed tracing is missing datadog support #593

christian-roggia opened this issue May 13, 2021 · 4 comments · Fixed by #600
Labels
corp/m8 Up for M8 at Ory Corp. good first issue A good issue to tackle when being a novice to the project. help wanted We are looking for help on this one.

Comments

@christian-roggia
Copy link

The rest of the ory stack is currently supporting datadog as distributed tracing provider while Keto doesn't.
@aeneasr
Copy link
Member

aeneasr commented May 17, 2021

I believe tracing is merged on master @zepatrik ?

@zepatrik
Copy link
Member

We have the standard Ory tracing capabilities since #536. Can you pin-point the difference between Keto and some other project you are referring to @christian-roggia ?

@christian-roggia
Copy link
Author

Ory keto currently supports only jaeger tracing:
https://www.ory.sh/keto/docs/reference/configuration/

Other ory products support also datadog, zipkin and other tracing platforms:
https://www.ory.sh/hydra/docs/reference/configuration/

@zepatrik
Copy link
Member

I see, that actually is just a docs/config schema issue then. The code is capable of any of those but we forgot to add it to the config schema.

@zepatrik zepatrik added docs good first issue A good issue to tackle when being a novice to the project. help wanted We are looking for help on this one. labels May 17, 2021
@aeneasr aeneasr mentioned this issue May 17, 2021
Merged
5 tasks
@zepatrik zepatrik added the corp/m8 Up for M8 at Ory Corp. label May 26, 2021
aeneasr added a commit that referenced this issue Jun 2, 2021
@aeneasr
fix: add missing tracers (#600)
aa263be 
Closes #593
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
corp/m8 Up for M8 at Ory Corp. good first issue A good issue to tackle when being a novice to the project. help wanted We are looking for help on this one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add missing tracers ory/keto
3 participants
@aeneasr @zepatrik @christian-roggia