Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check REST API should return JSON Object #406

Closed
aeneasr opened this issue Jan 25, 2021 · 0 comments
Closed

Check REST API should return JSON Object #406

aeneasr opened this issue Jan 25, 2021 · 0 comments
Assignees
@zepatrik
Labels
bug Something is not working. corp/m5 Up for M5 at Ory Corp. help wanted We are looking for help on this one.
Milestone
Next Gen Keto - f...

Comments

@aeneasr
Copy link
Member

aeneasr commented Jan 25, 2021

Describe the bug

Currently, the /check JSON api returns a JSON string. Instead, it should return a JSON object. Most integrations are not suited well to deal with plain JSON strings as response types. Additionally, this allows us to add more things in the future without breaking the API.
@aeneasr aeneasr added bug Something is not working. corp/m5 Up for M5 at Ory Corp. labels Jan 25, 2021
@aeneasr aeneasr added the help wanted We are looking for help on this one. label Feb 10, 2021
zepatrik added a commit that referenced this issue Feb 23, 2021
@zepatrik
fix: check REST API returns JSON object
b203269 
closes #406
@zepatrik zepatrik mentioned this issue Feb 23, 2021
Merged
5 tasks
zepatrik added a commit that referenced this issue Feb 23, 2021
@zepatrik
fix: check REST API returns JSON object (#460)
501dcff 
closes #406
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepatrik zepatrik

Labels
bug Something is not working. corp/m5 Up for M5 at Ory Corp. help wanted We are looking for help on this one.
Projects
None yet
Milestone
Next Gen Keto - first working version
Development

No branches or pull requests
2 participants
@aeneasr @zepatrik