fix: properly lex imports in OPL

ory · Sep 29, 2022 · f2ad058 · f2ad058
1 parent 3724528
commit f2ad058
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 2 deletions.
diff --git a/internal/schema/.snapshots/TestLexer-suite=snapshots-import_statement.json b/internal/schema/.snapshots/TestLexer-suite=snapshots-import_statement.json
@@ -0,0 +1,13 @@
+[
+  "'import'",
+  "{",
+  "'Foo'",
+  ",",
+  "'Bar'",
+  ",",
+  "'Baz'",
+  "}",
+  "'from'",
+  "'@ory/keto-...'",
+  "EOF"
+]
diff --git a/internal/schema/lexer.go b/internal/schema/lexer.go
@@ -307,7 +307,7 @@ func lexBlockComment(l *lexer) stateFn {
 func lexStringLiteral(l *lexer) stateFn {
 	r := l.next()
 	l.ignore()
-	l.acceptRun(digits + letters)
+	l.acceptRun(digits + letters + "@/-")
 	if l.peek() != r {
 		return l.errorf("unclosed string literal")
 	}

diff --git a/internal/schema/lexer_test.go b/internal/schema/lexer_test.go
@@ -15,6 +15,7 @@ var lexingErrorTestCases = []struct{ name, input string }{
 
 var lexableTestCases = []struct{ name, input string }{
 	{"empty", ""},
+	{"import statement", "import { Foo, Bar, Baz } from '@ory/keto-namespace-types'"},
 	{"single class", `
 class name implements Namespace {
 	metadata = {
@@ -117,7 +118,6 @@ func TestLexer(t *testing.T) {
 					}
 					if item.Typ == itemEOF {
 						t.Fatal("reached EOF, but expected error")
-						break
 					}
 				}
 				l.next()

diff --git a/internal/schema/parser_test.go b/internal/schema/parser_test.go
@@ -17,6 +17,8 @@ var parserTestCases = []struct {
 	name, input string
 }{
 	{"full example", `
+  import { Namespace, SubjectSet, FooBar, Anything } from '@ory/keto-namespace-types'
+
   class User implements Namespace {
 	related: {
 	  manager: User[]