fix: tiny stuff (#1211)

* fix: tracing in persistence.sql.TraverseSubjectSetRewrite * fix: incorrect HTTP return code
ory · Jan 30, 2023 · 719a7d5 · 719a7d5
1 parent 05ec2da
commit 719a7d5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/internal/persistence/sql/traverser.go b/internal/persistence/sql/traverser.go
@@ -127,6 +127,8 @@ LIMIT ?
 }
 
 func (t *Traverser) TraverseSubjectSetRewrite(ctx context.Context, start *relationtuple.RelationTuple, computedSubjectSets []string) (res []*relationtuple.TraversalResult, err error) {
+	ctx, span := t.d.Tracer(ctx).Tracer().Start(ctx, "persistence.sql.TraverseSubjectSetRewrite")
+	defer otelx.End(span, &err)
 
 	namespaceManager, err := t.d.Config(ctx).NamespaceManager()
 	if err != nil {
@@ -145,9 +147,6 @@ func (t *Traverser) TraverseSubjectSetRewrite(ctx context.Context, start *relati
 	}
 
 	if len(relations) > 0 {
-		_, span := t.d.Tracer(ctx).Tracer().Start(ctx, "persistence.sql.TraverseSubjectSetRewrite")
-		defer otelx.End(span, &err)
-
 		var rows relationTuples
 
 		query := t.p.queryWithNetwork(ctx)

diff --git a/internal/swagger_types.go b/internal/swagger_types.go
@@ -3,7 +3,7 @@
 
 package internal
 
-// Empty responses are sent when, for example, resources are deleted. The HTTP status code for empty responses is typically 201.
+// Empty responses are sent when, for example, resources are deleted. The HTTP status code for empty responses is typically 204.
 //
 // swagger:response emptyResponse
 // nolint:deadcode,unused