test: add relationtuple definition tests (#415)

ory · Jan 27, 2021 · 2e3dcb2 · 2e3dcb2
1 parent 41980ba
commit 2e3dcb2
Show file tree

Hide file tree

Showing 2 changed files with 410 additions and 4 deletions.
diff --git a/internal/relationtuple/definitions.go b/internal/relationtuple/definitions.go
@@ -268,12 +268,15 @@ func (r *InternalRelationTuple) FromURLQuery(query url.Values) (*InternalRelatio
 }
 
 func (r *InternalRelationTuple) ToURLQuery() url.Values {
-	return url.Values{
+	vals := url.Values{
 		"namespace": []string{r.Namespace},
 		"object":    []string{r.Object},
 		"relation":  []string{r.Relation},
-		"subject":   []string{r.Subject.String()},
 	}
+	if r.Subject != nil {
+		vals.Set("subject", r.Subject.String())
+	}
+	return vals
 }
 
 func (q *RelationQuery) FromProto(query *acl.ListRelationTuplesRequest_Query) *RelationQuery {
@@ -350,13 +353,13 @@ func (r *InternalRelationTuple) Interface() interface{} {
 	return r
 }
 
-func NewProtoRelationCollection(rels []*acl.RelationTuple) cmdx.Table {
+func NewProtoRelationCollection(rels []*acl.RelationTuple) *relationCollection {
 	return &relationCollection{
 		protoRelations: rels,
 	}
 }
 
-func NewRelationCollection(rels []*InternalRelationTuple) cmdx.Table {
+func NewRelationCollection(rels []*InternalRelationTuple) *relationCollection {
 	return &relationCollection{
 		internalRelations: rels,
 	}