fix: race condition in setup

internal/driver/daemon.go

@@ -120,10 +120,16 @@ func (r *RegistryDefault) ServeAll(ctx context.Context) error {
 
 	eg := &errgroup.Group{}
 
-	eg.Go(r.serveRead(innerCtx, doneShutdown))
-	eg.Go(r.serveWrite(innerCtx, doneShutdown))
-	eg.Go(r.serveOPLSyntax(innerCtx, doneShutdown))
-	eg.Go(r.serveMetrics(innerCtx, doneShutdown))
+	// We need to separate the setup (invoking the functions that return the serve functions) from running the serve
+	// functions to mitigate race contitions in the HTTP router.
+	for _, serve := range []func() error{
+		r.serveRead(innerCtx, doneShutdown),
+		r.serveWrite(innerCtx, doneShutdown),
+		r.serveOPLSyntax(innerCtx, doneShutdown),
+		r.serveMetrics(innerCtx, doneShutdown),
+	} {
+		eg.Go(serve)
+	}
 
 	return eg.Wait()
 }
@@ -232,7 +238,7 @@ func multiplexPort(ctx context.Context, log *logrusx.Logger, addr string, router
 	})
 
 	eg.Go(func() error {
-		if err := restS.Serve(httpL); !errors.Is(err, http.ErrServerClosed) && !errors.Is(err, cmux.ErrServerClosed) {
+		if err := restS.Serve(httpL); !errors.Is(err, http.ErrServerClosed) && !errors.Is(err, cmux.ErrServerClosed) { // <<- Lookup
 			return errors.WithStack(err)
 		}
 		return nil
@@ -513,7 +519,7 @@ func (r *RegistryDefault) metricsRouter(ctx context.Context) http.Handler {
 	router := httprouter.New()
 
 	r.PrometheusManager().RegisterRouter(router)
-	r.MetricsHandler().SetRoutes(router)
+	r.MetricsHandler().SetRoutes(router) // <<- Register (races with lookup)
 	n.UseHandler(router)
 	n.Use(r.PrometheusManager())