Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runtime): allow to automatically set GOMAXPROCS according to linux container quota #2034

Merged
merged 2 commits into from
Aug 31, 2020

Conversation

drwatsno
Copy link
Contributor

Related issue

#2033

Proposed changes

ADD cgroups.v1.auto_max_procs_enabled option. Defaults to false
If true, sets GOMAXPROCS automatically according to cpu quota

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

cmd/root.go Outdated Show resolved Hide resolved
cmd/server/handler.go Outdated Show resolved Hide resolved
@drwatsno
Copy link
Contributor Author

@aeneasr it looks like tests are not needed

@aeneasr aeneasr merged commit 39652ac into ory:master Aug 31, 2020
@aeneasr
Copy link
Member

aeneasr commented Aug 31, 2020

Awesome, thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants