Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add authenticated_at to type HandledConsentRequest #1684

Closed
marcohutzsch1234 opened this issue Jan 8, 2020 · 2 comments
Closed

Add authenticated_at to type HandledConsentRequest #1684

marcohutzsch1234 opened this issue Jan 8, 2020 · 2 comments

Comments

@marcohutzsch1234
Copy link
Contributor

Is your feature request related to a problem? Please describe.

When we ask hydra for all accepted consents for a subject we want to show the subject the date, when the latest consent was accepted. This value exists in the db but is not accessible via go-sdk.

Describe the solution you'd like

We had the idea of adding the value to the mentioned struct. Would you accept a PR for that?

Describe alternatives you've considered

No idea.
@aeneasr
Copy link
Member

aeneasr commented Jan 10, 2020

I think authenticated_at is currently not part of the consent itself but only of the authentication session. Do you need the time of the authentication itself, or the time where the consent request was granted?

DennisPattmann5012 pushed a commit to DennisPattmann5012/hydra that referenced this issue Jan 13, 2020
@marcohutzsch1234
consent: add field for handled at to consent request type and database
a1da137 
References: ory#1684

Co-authored-by: Marco Hutzsch <[email protected]>
@DennisPattmann5012 DennisPattmann5012 mentioned this issue Jan 13, 2020
Merged
6 tasks
DennisPattmann5012 pushed a commit to DennisPattmann5012/hydra that referenced this issue Jan 15, 2020
@marcohutzsch1234
consent: add field for handled at to consent request type and database
54dfc08 
References: ory#1684

Co-authored-by: Marco Hutzsch <[email protected]>
DennisPattmann5012 pushed a commit to DennisPattmann5012/hydra that referenced this issue Jan 21, 2020
@marcohutzsch1234
consent: add field for handled at to consent request type and database
dbc9743 
References: ory#1684

Co-authored-by: Marco Hutzsch <[email protected]>
DennisPattmann5012 pushed a commit to DennisPattmann5012/hydra that referenced this issue Jan 21, 2020
@marcohutzsch1234
consent: add field for handled at to consent request type and database
15ef449 
References: ory#1684

Co-authored-by: Marco Hutzsch <[email protected]>
DennisPattmann5012 pushed a commit to DennisPattmann5012/hydra that referenced this issue Jan 21, 2020
@marcohutzsch1234
consent: add field for handled at to consent request type and database
a1c5ef8 
References: ory#1684

Co-authored-by: Marco Hutzsch <[email protected]>
@marcohutzsch1234
Copy link
Contributor Author

Closing Issue because discussion moved to PR: #1689

aeneasr pushed a commit that referenced this issue Feb 3, 2020
@DennisPattmann5012 @marcohutzsch1234
feat(consent)!: Track handled_at for consent requests (#1689)
d9308fa 
This patch adds a feature where handling (accepting or rejecting) a consent request causes a time stamp (`handled_at`) to be updated.

This patch includes schema changes that required `hydra migrate sql` to be applied.

Closes #1684

Co-authored-by: Marco Hutzsch <[email protected]>
eli-zh pushed a commit to eli-zh/hydra that referenced this issue Mar 22, 2020
@DennisPattmann5012 @marcohutzsch1234 @eli-zh
feat(consent)!: Track handled_at for consent requests (ory#1689)
1279ad1 
This patch adds a feature where handling (accepting or rejecting) a consent request causes a time stamp (`handled_at`) to be updated.

This patch includes schema changes that required `hydra migrate sql` to be applied.

Closes ory#1684

Co-authored-by: Marco Hutzsch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aeneasr @marcohutzsch1234