fix: detect unique violation on MySQL

ory · Nov 14, 2023 · e2922c4 · e2922c4
1 parent dd52765
commit e2922c4
Showing 1 changed file with 16 additions and 10 deletions.
diff --git a/persistence/sql/persister_consent.go b/persistence/sql/persister_consent.go
@@ -787,17 +787,23 @@ func (p *Persister) FlushInactiveLoginConsentRequests(ctx context.Context, notAf
 }
 
 func (p *Persister) mySQLConfirmLoginSession(ctx context.Context, session *flow.LoginSession) error {
-	err := p.Connection(ctx).Create(session)
+	err := sqlcon.HandleError(p.Connection(ctx).Create(session))
+	if err == nil {
+		return nil
+	}
+
+	if !errors.Is(err, sqlcon.ErrUniqueViolation) {
+		return err
+	}
+
+	n, err := p.Connection(ctx).
+		Where("id = ? and nid = ?", session.ID, session.NID).
+		UpdateQuery(session, "authenticated_at", "subject", "identity_provider_session_id", "remember")
 	if err != nil {
-		n, err := p.Connection(ctx).
-			Where("id = ? and nid = ?", session.ID, session.NID).
-			UpdateQuery(session, "authenticated_at", "subject", "identity_provider_session_id", "remember")
-		if err != nil {
-			return errors.WithStack(sqlcon.HandleError(err))
-		}
-		if n == 0 {
-			return errorsx.WithStack(x.ErrNotFound)
-		}
+		return errors.WithStack(sqlcon.HandleError(err))
+	}
+	if n == 0 {
+		return errorsx.WithStack(x.ErrNotFound)
 	}
 
 	return nil