Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Tolerate nil secret when tokenEndpointAuthMethod: none #53

Merged
merged 1 commit into from
Mar 26, 2020
Merged

fix: Tolerate nil secret when tokenEndpointAuthMethod: none #53

merged 1 commit into from
Mar 26, 2020

Conversation

clement-buchart
Copy link
Contributor

Fixes #52

@CLAassistant
Copy link

CLAassistant commented Mar 25, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@clement-buchart clement-buchart force-pushed the handle-nil-secret branch 3 times, most recently from 2eacdb0 to daa49e6 Compare March 25, 2020 14:20
@aeneasr
Copy link
Member

aeneasr commented Mar 25, 2020

Would you be able to add a test to cover the original failing issue? :)

@clement-buchart
Copy link
Contributor Author

Done

@aeneasr
Copy link
Member

aeneasr commented Mar 26, 2020

Awesome, thank you!

@aeneasr aeneasr merged commit ce3ca78 into ory:master Mar 26, 2020
@clement-buchart clement-buchart mentioned this pull request Mar 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maester crash when creating a client with tokenEndpointAuthMethod: none
3 participants
@clement-buchart @CLAassistant @aeneasr