-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAuth2 client CRD metadata issue #71
Comments
Hello there. If I see correctly this was changed in #68 when we updated the crd to match new openAPI specs. The crd is auto generated from code by kubebuilder. IMHO we would need to specify that it an object type with kubebuilder annotations and regenerate the crd |
fix: oauth client metadata as object in CRD (#71)
@Demonsthere @aeneasr Would it be possible to release a new maester image version along with updated helm chart? |
Hi folks,
Any reason why in recent release metadata type in
hydra.ory.sh_oauth2clients.yaml
has changed from object to byte string?Expected:
Actual:
The only way I found to set object there is to
base64encode
the json string. But, in our case it breaks IDP, as we should do base64 decoding there.And, it also seems that Hydra
/clients
endpoint didn't change in that perspective - metadata is still an object.Previously, we were able to specify it in our
yaml
like this:And get response from hydra with appropriate object:
And now if we want to specify object, we specify base64 encoded json string in yaml:
And we get it as-is from hydra
/clients
endpoints:Please, let me know if it was done purposely or is maybe some auto-generation issue?
I can do the PR, just let me know if I'm missing some puzzle here.
@colunira @aeneasr @Demonsthere
The text was updated successfully, but these errors were encountered: