Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass JWK for singing so that KeyID is set in JWTs #799

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

mitar
Copy link
Contributor

@mitar mitar commented Mar 7, 2024

It is harder to validate generated JWTs because currently they do not include a key ID in the header. Even when key ID exists in the JWK used for signing. The reason is that Fosite currently removes this metadata information, but it is not necessary to remove it, our signing library uses it and knows how to use JWKs, even more, it adds key ID automatically if it is available and provided with a JWK.

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

@aeneasr aeneasr enabled auto-merge (squash) July 9, 2024 13:19
@aeneasr aeneasr merged commit 11cc702 into ory:master Sep 16, 2024
5 checks passed
@mitar mitar mentioned this pull request Sep 16, 2024
6 tasks
@tilgovi
Copy link

tilgovi commented Nov 12, 2024

@aeneasr is there anything I can do to help get this released and update ory/hydra to use it? I think this is blocking ory/hydra#3573.

@aeneasr
Copy link
Member

aeneasr commented Nov 13, 2024

We accept PRs!

@tilgovi
Copy link

tilgovi commented Nov 13, 2024

@aeneasr I can't PR a release here, can I?

@tilgovi
Copy link

tilgovi commented Nov 13, 2024

If you can make a fosite release, I think my team can work on the PR to update Hydra and fix ory/hydra#3573.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants