Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: new sidebarv2 #1823

Merged
merged 75 commits into from
Aug 30, 2024
Merged

fix: new sidebarv2 #1823

merged 75 commits into from
Aug 30, 2024

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Aug 12, 2024

  • chore: update docusaurus to 3.X
  • chore: move the message descriptions to their own file
  • chore: format
  • fix: compilation issues
  • chore: formatting
  • chore: upgrade versions in workflows
  • chore: downgrade mermaid to 9.3
  • chore: format
  • chore: add sharp??
  • chore: format
  • chore: u
  • fix: visual regressions
  • chore: format
  • chore: cleanup
  • feat(wip): rework sidebar
  • fix: new sidebar
  • fix: new sidebar
  • fix: links
  • fix: new sidebar
  • fix: new sidebar
  • fix: new sidebar add oauth2
  • fix: add keto and reorder a bit
  • fix: new sidebar
  • chore: update docusaurus to 3.X
  • chore: move the message descriptions to their own file
  • chore: format
  • fix: compilation issues
  • chore: formatting
  • chore: downgrade mermaid to 9.3
  • chore: format
  • fix: visual regressions
  • feat(wip): rework sidebar
  • chore: format
  • chore: format
  • fix: build
  • fix: sidebar
  • chore: fix build
  • chore: fix build
  • chore: fix build
  • chore: fix build
  • chore: adjust the new sidebar (chore: adjust the new sidebar #1788)
  • chore: remove licenses for now
  • fix: ory identities overview
  • chore: remove unneeded overviews
  • fix: migration tutorial
  • fix: add self-hosting and top bar items
  • fix: merge identities intro with kratos intro
  • fix: simply Ory CLI reference sidebar
  • fix: simply Ory CLI reference sidebar
  • fix: simply Ory CLI reference sidebar
  • fix: simply Ory CLI reference sidebar
  • fix: broken link
  • chore: fix broken links
  • chore: add missing docs to sidebar
  • u
  • u

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@vinckr
Copy link
Member Author

vinckr commented Aug 30, 2024

missing from sidebar:

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really is, so good.

@vinckr vinckr merged commit 1f8f7d2 into master Aug 30, 2024
10 checks passed
@vinckr vinckr deleted the vinckr/newSidebarFINAL branch August 30, 2024 13:55
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinckr please address the comments. Sorry that I missed them during initial review. Right now, several google search results are broken, like this link:

Screenshot 2024-08-31 at 15 59 08 Screenshot 2024-08-31 at 15 59 10

docs/kratos/social-signin/30_apple.mdx Show resolved Hide resolved
docs/kratos/bring-your-own-ui/01_overview.mdx Show resolved Hide resolved
docs/guides/ip-allowlist.mdx Show resolved Hide resolved
docs/kratos/mfa/30_sms.mdx Show resolved Hide resolved
docs/kratos/passwordless/00_overview.mdx Show resolved Hide resolved
docs/kratos/passwordless/06_code.mdx Show resolved Hide resolved
@vinckr vinckr mentioned this pull request Sep 1, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants