Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: document two-step registration #1694

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Conversation

hperl
Copy link
Collaborator

@hperl hperl commented Mar 27, 2024

Screenshot

two-step-registration

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@aeneasr
Copy link
Member

aeneasr commented Mar 27, 2024

Could you add screenshots please?

@hperl
Copy link
Collaborator Author

hperl commented Mar 27, 2024

Could you add screenshots please?

I already added it to the docs, and now also to the issue description :)

Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hperl hperl merged commit 96deea3 into master Mar 28, 2024
10 checks passed
@hperl hperl deleted the hperl/two-step-registration branch March 28, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants