fix: add dark mode for diagrams (#1213) #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the dark mode theme for mermaid diagrams that match the selected theme. Close #1213 Signed-off-by: iverly <[email protected]>
iverly
requested review from
vinckr,
kmherrmann,
aeneasr,
zepatrik and
piotrmsc
as code owners
vinckr
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Thanks a lot for the contribution!
This fixes our issues with darkmode diagrams 🎉
It works great when I have dark mode enabled on the docs and then navigate to a page that has a mermaid diagram.
One thing that is still not fixed it seems:
If I am already on the page (for example this one) and then toggle dark mode, its the old unfixed version. A page refresh F5 fixes the diagram, but that might not be obvious to users)
Still this is a 90% fix IMO, thanks again 👍
zepatrik
reviewed
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the dark mode theme for mermaid diagrams that match the selected theme.
Related Issue or Design Document
#1213
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
Further comments
This fix only applies after a page refresh if the page has a diagram. This is due to the mermaid package refreshing it empty (and I don't know why).
We can open a new issue to fix this bug later, while still keeping diagrams more visible than today.