Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: consistency #1577

Merged
merged 14 commits into from
Oct 16, 2023
Merged

docs: consistency #1577

merged 14 commits into from
Oct 16, 2023

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Oct 13, 2023

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments


## Replication Lag

It's important to note that Ory Network operates with a replication lag of approximately 4.8 seconds. This means that even under
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It's important to note that Ory Network operates with a replication lag of approximately 4.8 seconds. This means that even under
It's important to note that Ory Network operates with a replication lag of approximately 5 seconds. This means that even under

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is 4.8 seconds though ;)

Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please headings instead of bolding 🙏

Removed a lot of the AI speak to make it more readable and clear.

I can also do a style update, lemme know

docs/api/consistency.mdx Outdated Show resolved Hide resolved
docs/api/consistency.mdx Outdated Show resolved Hide resolved
docs/api/consistency.mdx Outdated Show resolved Hide resolved
docs/api/consistency.mdx Outdated Show resolved Hide resolved
docs/api/consistency.mdx Outdated Show resolved Hide resolved
docs/api/consistency.mdx Outdated Show resolved Hide resolved
docs/api/consistency.mdx Outdated Show resolved Hide resolved
Comment on lines 51 to 56
## Conclusion

In conclusion, understanding the consistency levels offered by Ory's APIs is essential for optimizing query performance in a
global system where data is distributed across continents. By choosing the appropriate consistency level, you can strike the right
balance between data freshness and query latency, ensuring that your application functions effectively in the Ory Network
environment.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would cut this, it adds nothing IMO.

kmherrmann
kmherrmann previously approved these changes Oct 13, 2023
Copy link
Contributor

@kmherrmann kmherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestions, thanks!

docs/api/consistency.mdx Outdated Show resolved Hide resolved
docs/api/consistency.mdx Outdated Show resolved Hide resolved
@aeneasr aeneasr merged commit ce2b351 into master Oct 16, 2023
8 checks passed
@aeneasr aeneasr deleted the consistency branch October 16, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants