(fix) add response headers in fetch client

[melloware]

Fix #1694 add response headers in fetch client

[soartec-lab]

Hi @melloware, Please give me some time to think about this response.

[melloware]

Yep converting to draft was just seeing if that is what the OP meant!

[nimo23]

@melloware Thanks, the PR looks good to me. I think Orval doesn't need to check to add the headers to the response only when custom headers are detected in openapi.yaml. Headers should be included by default.

[soartec-lab]

Good update. I have added comments where additional updates are needed.

[melloware]

@soartec-lab you are more familiar with this code did you want to submit a PR and I can close this one?

[melloware]

OK changes made

[soartec-lab]

@melloware

Thanks!
can you regenerate the fetch client and update the custom-fetch implement in sample apps ?

[melloware]

@soartec-lab not sure what you mean by regenerate but i updated orval.config.js and custom-fetch.js in samples directory.

[soartec-lab]

@melloware

Sorry for confusing you. To be more precise, I would like you to regenerate the sample app using the following command.

cd samples
yarn generate-api --force

Your change adds headers to returnType, so the returnType of the sample app generated by orval should also be updated.

[melloware]

Weird when I run that command in samples I get..

 Tasks:    0 successful, 21 total
Cached:    0 cached, 21 total
  Time:    1.957s
Failed:    react-query-basic#generate-api, react-query-form-data#generate-api, react-query-form-url-encoded#generate-api

 ERROR  run failed: command  exited (1)

[melloware]

Would you like to just merge this PR and then you can take a look?

[soartec-lab]

@melloware
Can I run it and put commits on this branch ?

[melloware]

Oh sure thing my branch should be editable for you!

[soartec-lab]

@melloware
Can you try cherry-pick this ?

13533d5

Or if you like, you can switch to this PR.

#1699