fix: faker bigint support #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marfyy
force-pushed
the
fix/faker-bigint
branch
from
2e70bcd to
6b1be15
Compare
|
The https://github.com/orval-labs/orval/blob/master/packages/mock/src/faker/constants.ts Can we change it to be managed by constants instead of function? |
|
good question @Marfyy can you take a look? |
3 tasks
|
I fixed this by #1697 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Fix #1472
If orval config uses override useBigInt, faker will be generated with faker.number.bigInt. I also added support for format double/float, to use faker.number.float. if useBigInt is not set, it will default back to faker.number.int
I appended the existing
tests/specifications/format.yaml, and changed the name intests/configs/mock.config.tsfrom useDates, to formats, to better reflect its content with the new test scenariosTodos
Steps to Test or Reproduce
Running locally against
tests/configs/mock.config.ts, the config formats tests to generate the new number type/format combinations