Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom client example to include a question mark before query parameters #1667

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

dob9601
Copy link
Contributor

@dob9601 dob9601 commented Oct 19, 2024

Status

READY

Description

Fix the custom fetch client example to include a question mark before any query parameters.

Closes #1666
Closes #482

@dob9601 dob9601 mentioned this pull request Oct 19, 2024
melloware
melloware previously approved these changes Oct 19, 2024
@melloware
Copy link
Collaborator

You might have to run NPM run format.

@dob9601
Copy link
Contributor Author

dob9601 commented Oct 19, 2024

Good shout - all formatted

@melloware melloware merged commit 14c36fa into orval-labs:master Oct 19, 2024
2 checks passed
@melloware
Copy link
Collaborator

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation mistake Missing question mark that separate URL from query string parameters
2 participants