fix(angular): add request overloads based on observe property #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melloware
previously approved these changes
Sep 18, 2024
|
Hmm looks like a build failure. |
|
It seems to me that the yarn.lock has not been updated with yesterday's 7.1.1 release. |
|
Agreed @anymaniax ? |
anymaniax
previously approved these changes
Sep 18, 2024
|
OK made progress now some test failures! |
QuietNatu
force-pushed
the
fix/angular/add-observe-function-overloads
branch
from
a76c24d to
e8e4a22
Compare
melloware
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Fixes #1631
generateImplementationto add function overloads whenisRequestOptionsistrue.observeto a request, it's return type will match what is returned by theHttpClient.Todos