Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct-enum-handling #1386

Merged
merged 1 commit into from
May 24, 2024

Conversation

danyadanch
Copy link
Contributor

Status

WIP, fixes: #1385

@melloware melloware added the zod Zod related issue label May 20, 2024
Copy link
Member

@soartec-lab soartec-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the nice update. I think the source code is good, but the status written in the PR description is that it is WIP. Is this already ready for merging?

@soartec-lab soartec-lab self-assigned this May 23, 2024
@danyadanch
Copy link
Contributor Author

@soartec-lab it was just proof of concept that fixes my bug, if code is ok i can change state to ready

@soartec-lab soartec-lab merged commit d5574cd into orval-labs:master May 24, 2024
2 checks passed
@soartec-lab
Copy link
Member

@danyadanch
i see this good so i merged this
thank you for good update 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
zod Zod related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange enum generation while using anyOf in schema
3 participants