Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add option to apply biome to generated files #1321

Merged
merged 6 commits into from
Apr 21, 2024

Conversation

soartec-lab
Copy link
Member

Status

READY

Description

fix #1298

I Added option to apply Biome to automatically generated files.
Biome also has a command that runs only format, but will be orval supports the check --apply command that runs both format and lint. Because, if you only want to apply either format or lint, you can control it with the Biome configuration file.

Related PRs

none

Todos

  • Tests
  • Documentation
  • Changelog Entry (unreleased)

Steps to Test or Reproduce

  1. execute orval cli command with --biome option and make sure biome executes together.
orval --biome
  1. you define biome to true in orval.config.js like a bellow, then execute orval and make sure biome executes together.
import { defineConfig } from 'orval';

export default defineConfig({
  petstoreFile: {
    input: {
      target: './petstore.yaml',
    },
    output: {
      client: 'swr',
      target: 'src/gen/endpoints',
      schemas: 'src/gen/model',
      biome: true,
    },
  },
});

@melloware melloware added the enhancement New feature or request label Apr 21, 2024
@melloware melloware added this to the 6.28.0 milestone Apr 21, 2024
@soartec-lab
Copy link
Member Author

@melloware
Thank you for reviewed this. I merge this.

@soartec-lab soartec-lab merged commit 5f5dc17 into orval-labs:master Apr 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to use Biome in addition to Prettier
2 participants