feat: don't inject generated files into hook command #1193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkanii
suggested changes
Feb 1, 2024
There was a problem hiding this comment.
For me this PR is a BC, this will generate an error for each Orval user if this hook is implemented.
You need to accept both functions names, and deprecate afterAllFilesWrite.
afterAllFilesWrite needs to be removed in 7.0.0 version.
And don't forget to update documentation:
|
i will revert it back to allFilesWrite then even though it is grammatically incorrect. ITs an easier fix in the short term |
|
Just revert the documentation part in 3095de2, I'll accept the PR quickly. |
|
Yep PR submitted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes 1 spot that
afterAllFilesWrittenwas missed