Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sort schemas after reading files (#1159) #1176

Closed
wants to merge 1 commit into from

Conversation

rnm-sxm
Copy link
Contributor

@rnm-sxm rnm-sxm commented Jan 23, 2024

Status

WIP

Description

Sort schemas after reading input files and before generating output.

Related PRs

Fix #1159

Todos

  • Tests
  • Documentation (N/A)
  • Changelog Entry (unreleased)

Steps to Test or Reproduce

Extract the workspace from reproduce.tar.gz

# generate the OpenApi schema
> python3 gen.py

# generate Typescript using orval
> npx orval

# Make a copy of the output
> cp gen/reproduce.ts gen/reproduce-one.ts

# Rerun the generator
> npx orval

# diff the two outputs
> diff gen/reproduce-one.ts gen/reproduce.ts

The two output files should be identical.

@melloware melloware added this to the 6.24.0 milestone Jan 23, 2024
@melloware melloware added the enhancement New feature or request label Jan 23, 2024
@melloware
Copy link
Collaborator

Looks like the tests are failing?

@rnm-sxm
Copy link
Contributor Author

rnm-sxm commented Jan 24, 2024

I'll fix it.

@rnm-sxm
Copy link
Contributor Author

rnm-sxm commented Jan 24, 2024

Fix will be resubmitted with fixes and corrected commit message.

@rnm-sxm rnm-sxm closed this Jan 24, 2024
@rnm-sxm rnm-sxm deleted the fix_random_generated_ts branch January 24, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reproducable TypeScript output
2 participants