-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adjust SecondParameter utility type #1125
Conversation
Can you please open an Issue ticket explaining what is poorly typed and show us how this ticket makes it better? |
@soartec-lab since this affects SWR can you review this change? |
Of cource 👍 I'll review this, so could you assign me reviewer for this PR ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change will affect the case where global mutator
is used, and I don't think it will affect the generated swr
custom hook alone.
At the same time, we thought it would have the following advantages:
- Can be expressed in a simpler and more understandable form
- Being able to remove eslint disable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(excuse me. I got a little confused and ended up editing the comment several times.)
I reviewed it. But i would like to confirm the scope of the effect a little more, so if possible, could you give me some time?
No problem just let me know what your final decision is. |
@melloware In the first place, there will be no mismatch due to the case where the second argument does not exist, and even if it were to happen, there would be no problem because the type was specified as |
Status
READY
Description
Fixes the poorly typed SecondParameter utility type.