Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 0.57.0 #27

Merged
merged 2 commits into from
Sep 18, 2018
Merged

Support 0.57.0 #27

merged 2 commits into from
Sep 18, 2018

Conversation

ikesyo
Copy link
Collaborator

@ikesyo ikesyo commented Sep 13, 2018

Patching RCTNativeAnimatedNodesManager.h is not needed anymore: facebook/react-native@7525f38

diff --git a/lib/cocoapods-fix-react-native/versions/0_56_1-post.rb b/lib/cocoapods-fix-react-native/versions/0_57_0-post.rb
index 6fa7bb7..4000375 100644
--- a/lib/cocoapods-fix-react-native/versions/0_56_1-post.rb
+++ b/lib/cocoapods-fix-react-native/versions/0_57_0-post.rb
@@ -52,9 +52,3 @@ def detect_missing_subspecs
 end
 
 detect_missing_subspecs
-
-# # https://github.com/facebook/react-native/pull/14664
-animation_view_file = 'Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h'
-animation_view_old_code = 'import <RCTAnimation/RCTValueAnimatedNode.h>'
-animation_view_new_code = 'import "RCTValueAnimatedNode.h"'
-patch_pod_file animation_view_file, animation_view_old_code, animation_view_new_code

Patching `RCTNativeAnimatedNodesManager.h` is not needed anymore.
@orta
Copy link
Owner

orta commented Sep 14, 2018

Yeah, let's kill the function and then this is good to go - thanks @ikesyo !

@ikesyo
Copy link
Collaborator Author

ikesyo commented Sep 18, 2018

Okay I'll remove it 👌

@ikesyo
Copy link
Collaborator Author

ikesyo commented Sep 18, 2018

@koenpunt @orta Just updated ✨

@koenpunt koenpunt merged commit db5a33d into orta:master Sep 18, 2018
@koenpunt
Copy link
Collaborator

Thanks! 🚀

@ikesyo ikesyo deleted the rn-0.57.0 branch September 18, 2018 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants