Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Automatic-Module-Name for JPMS #52

Open
danielfernandez opened this issue Mar 29, 2018 · 1 comment
Open

Add Automatic-Module-Name for JPMS #52

danielfernandez opened this issue Mar 29, 2018 · 1 comment

Comments

@danielfernandez
Copy link
Contributor

In order to have the OGNL jar artifact properly work as a dependency in JPMS (a required module in a Java 9+ modular application), OGNL should choose a module name that gives dependent software some kind of guarantee on the module name that should be used for it, whatever the version. This can be done even if OGNL is not turned yet into a module as such, by merely adding an Automatic-Module-Name: <name> entry to the MANIFEST.MF file.

This works as a kind of reserve for module names and allows software using OGNL to properly express OGNL as a dependency in a requires clause in module-info.java, even if OGNL has not been modularised yet.

Note there are two main approaches for module naming (see this). Apache Commons OGNL has already chosen the reverse-DNS approach (see their pom.xml) so it is org.apache.commons.ognl there, but given OGNL 3 and OGNL 4 will be completely package- and code-incompatible (ognl.* vs org.apache.commons.ognl.* packages), I'm not sure it would make sense to adopt org.apache.commons.ognl here too as a module name for the sake of compatibility. So using simply ognl as name could be a sensible option here too. Especially given the fact that Apache Commons OGNL seems dead.

@lukaszlenart
Copy link
Collaborator

Yes, 👍 for a simple name ognl. And yes, Commons OGNL seems to be dead, but I still have hope that I will return to it someday :(

Or maybe just incorporate changes from Commons OGNL into OGNL4 🤔

JCgH4164838Gh792C124B5 added a commit to JCgH4164838Gh792C124B5/ognl that referenced this issue Jun 30, 2019
- Lukasz indicated he approved the JPMS package name "ognl".
- Added the Automatic-Module-Name manifest-entry for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants