Overload NdCopy instead of adding a new argument for the 2.10 release #4377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Best one is for me to go ahead and merge the the git revert in release210 and rebase these changes in the release210 branch. |
vicentebolea
force-pushed
the
ndcopy-no-break-abi
branch
from
1a018d6
to
fbd9036
Compare
|
@anagainaru rebased |
vicentebolea
approved these changes
Oct 24, 2024
|
|
vicentebolea
force-pushed
the
ndcopy-no-break-abi
branch
from
fbd9036
to
ee1ee29
Compare
|
@vicentebolea great, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure how to add this only in the release and not master. I don't think we want this in 2.11
Required so that we can include #4359 in the 2.10 release without breaking the ABI.