Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak POSIX fail on EOF to kill heisenbug #4035

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Tweak POSIX fail on EOF to kill heisenbug #4035

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0142490
Tweak POSIX fail on EOF to kill heisenbug
eisenhauer Feb 14, 2024
5bc9947
retrigger CI
eisenhauer Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions source/adios2/toolkit/transport/file/FilePOSIX.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
/*
* Distributed under the OSI-approved Apache License, Version 2.0. See
* accompanying file Copyright.txt for details.
*
* FilePOSIX.cpp file I/O using POSIX I/O library
*
Expand Down Expand Up @@ -437,9 +435,19 @@ void FilePOSIX::Read(char *buffer, size_t size, size_t start)
{
if (m_FailOnEOF)
{
helper::Throw<std::ios_base::failure>(
"Toolkit", "transport::file::FilePOSIX", "Read",
"Read past end of file on " + m_Name + " " + SysErrMsg());
// we got an EOF on data that *should* be present,
// but maybe we've got filesystem consistency
// issues. We'll wait, but if the backoff time
// reaches 30 seconds (nearly 45 seconds total
// wait time) and we still don't have data, treat
// this as a real failure and throw an exception.
std::this_thread::sleep_for(std::chrono::nanoseconds(backoff_ns));
backoff_ns *= 2;
if (std::chrono::nanoseconds(backoff_ns) > std::chrono::seconds(30))
helper::Throw<std::ios_base::failure>(
"Toolkit", "transport::file::FilePOSIX", "Read",
"Read past end of file on " + m_Name + " trying to read " +
std::to_string(size) + " bytes " + SysErrMsg());
}
else
{
Expand Down
Loading