fix for ASAN issue related to JoinedDimArray handling in BP5 deserializer #3963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eisenhauer
previously approved these changes
Dec 12, 2023
There was a problem hiding this comment.
If this improves san results, it looks good. I'm still trying to sort out if the MinMax PR improves things, breaks other things, etc. It seems that you've got to remove the CTEST_CUSTOM_MEMCHECK_IGNORE list to run the sanitizer list that we were ignoring to get that to pass, then you really need to look to see if you've introduced anything new (bad) or just removed issues (good). My non-CI asan setup isn't flagging everything CI does, so I'm still trying to jump through the hoops that it appears that I need to (duplicating CI locally, etc.).
|
It fixes only one of the two problems related to joined array, apparently. |
use a vector of vectors rathen than vector of pointers to vectors. Also reuse/realloc a pointer in all steps that is freed in destructor only once.
pnorbert
force-pushed
the
fix-bp5deserializer-joinddimarray-asan
branch
from
c3b36cd
to
91f4ec3
Compare
eisenhauer
approved these changes
Dec 12, 2023
pnorbert
added a commit
to pnorbert/ADIOS2
that referenced
this pull request
Dec 12, 2023
* master: Have HDF5 write raise error if operator(s) requested (ornladios#3951) fix for ASAN issue related to JoinedDimArray handling in BP5 deserializer (ornladios#3963) New operator MDR, for refactoring floating point arrays using MGARD's new MDR extension. (ornladios#3826) restricted http transport from windows builds. XMLConfigTest: Add RemoveIO test adios2::core::ADIOS: Initialize new IO objects with config file removed unsused variable Update readme for heat transfer example with new location and build instructions Ignore tests with defects for now Adapt libfabric dataplane of SST to Cray CXI provider (ornladios#3672) ci: fix path to lsan suppressions, fix broken gh status post Use adios2_mode_readRandomAccess in matlab open to make it work for BP5 (ornladios#3956) Add Global Array Capabilities and Limitations Add Section for Anatomy of an ADIOS Program Enable Shell-Check for gh-actions scripts Enable Shell-Check for circle CI scripts Enable Shell-Check for tau contract scripts Enable Shell-Check for scorpio contract scripts Enable Shell-Check for lammps contract scripts Delete VTK code in examples Fix MATLAB bindings for MacOS (ornladios#3950) Set the compiler for the Kokkos DataMan example to what is used to build Kokkos Fix the HIP architecture CMAKE variable (ornladios#3931) perfstubs 2023-11-27 (845d0702) (ornladios#3944) Revert "Only rank 0 should print the initialization message in perfstub" Formatting Formatting Revision Added buffered data receive in the client side. A socket version of HTTP connector. Proxy server host is hardwired to "localhost" and port to 9999 Remote bpls: bpls -E bp4 -T "Library=HTTP" /remote_path/myVector_cpp.bp -d bpInts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix to free a
vector<...>*pointer in the destructor. However, this may be revised to use a vector instead of a pointer at all.