-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add mgard dependency to spack builds #3753
Conversation
4249c77
to
4479eda
Compare
ed31400
to
7dca7f6
Compare
8c6c611
to
e7574ae
Compare
e7574ae
to
c4f887d
Compare
c4f887d
to
41ed053
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me. Now that you are the first one to change the E4S base image for the ubuntu builds, can you comment on:
- Did you build with
--progress=plain
or similar to see how the buildcache hit rate was affected? - Is the time to build and push all the images affected much?
- Did the size of the resulting images change much?
You'll have to push again to get rid of the tmp
in the image tags everywhere. I forget if, in this project, that will dismiss my review. Just ping me if you need me to re-approve after pushing.
Oh, I had the auto-merge enabled for this and it merged before renaming the tags. I will follow up in another MR and report the information asked by you |
followup #3768 |
Closes #3752