Throw an error when unsupported parameters are used with the ZFP CUDA backend #3567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A fast last addition to the release @vicentebolea |
|
@anagainaru sounds good, we need to rebase this onto release_29 and change the base branch to release_29. |
|
@anagainaru I think that you have to amend and repush, the CI seems to have gotten stuck |
Co-authored-by: Norbert Podhorszki <[email protected]>
anagainaru
force-pushed
the
zfp-cuda-backend
branch
from
e3f2588
to
17c3f83
Compare
|
@vicentebolea resent If the checks pass please approve the PR and merge |
vicentebolea
approved these changes
Mar 29, 2023
vicentebolea
added a commit
that referenced
this pull request
Mar 29, 2023
Throw an error when unsupported parameters are used with the ZFP CUDA backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ZFP compressor supports only the
rateparameter when the GPU backend is used (even if the arrays are CPUs if ZFP is linked to CUDA, theaccuracyandprecisionparameters will result in errors). This PR makes the errors easier to understand.ZFP supported parameters:
This is something that might change soon so it will be updated (the main reason why I am not adding this in testing).