Set the CMAKE GPU architectures to what is used for Kokkos #3517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anagainaru how about including this for the 2.9.0 rather than 2.9.1. |
vicentebolea
pushed a commit
that referenced
this pull request
Mar 2, 2023
Set the CMAKE GPU architectures to what is used for Kokkos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the newly introduced
Kokkos_CUDA_ARCHITECTURESandKokkos_HIP_ARCHITECTURESIf the user sets the
-D CMAKE_CUDA_ARCHITECTURESto something else, the user defined variable will be used (the same for HIP) so we cover the case when the used intends to use a different architecture.