Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline engine heat transfer test #2263

Merged
merged 6 commits into from
May 19, 2020

Conversation

caitlinross
Copy link
Collaborator

No description provided.

@chuckatkins
Copy link
Contributor

Rebased on master after travis fix

@caitlinross caitlinross changed the title WIP: Inline heat transfer test Inline heat transfer test May 17, 2020
@caitlinross caitlinross changed the title Inline heat transfer test Inline engine heat transfer test May 17, 2020
@caitlinross
Copy link
Collaborator Author

@pnorbert I've added in a heat transfer test for the inline engine. Also I did add a bit to the documentation about the engine, though mostly just trying to clarify things. Is there anything specific that is unclear to you about the engine that I need to add?

@caitlinross caitlinross force-pushed the inline-tests branch 2 times, most recently from 1f17ff1 to 135fc05 Compare May 17, 2020 17:10
@pnorbert
Copy link
Contributor

I just wanted to make sure there is a working example in the release and the document is up to date. This PR is addressing that. Thank you.

@chuckatkins chuckatkins added this to the 2.6.0 Production Release milestone May 18, 2020
@chuckatkins chuckatkins changed the base branch from master to release_26 May 18, 2020 10:59
@chuckatkins chuckatkins merged commit d86339c into ornladios:release_26 May 19, 2020
chuckatkins pushed a commit that referenced this pull request May 19, 2020
Inline engine heat transfer test
@caitlinross caitlinross deleted the inline-tests branch March 11, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants