Skip to content

Commit

Permalink
Merge pull request #2466 from pnorbert/fix-aggregation-compression
Browse files Browse the repository at this point in the history
Enable missing combo: compression + aggregation. Fixes #2461
  • Loading branch information
pnorbert authored Sep 18, 2020
2 parents 66a2557 + f357ea5 commit 15b8642
Showing 1 changed file with 24 additions and 1 deletion.
25 changes: 24 additions & 1 deletion source/adios2/toolkit/format/bp/BPSerializer.tcc
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,30 @@ void BPSerializer::UpdateIndexOffsetsCharacteristics(size_t &currentPosition,
3 * sizeof(uint64_t) * dimensionsSize + 2; // 2 is for length
break;
}
// TODO: implement operators
case (characteristic_transform_type):
{
const size_t typeLength =
static_cast<size_t>(helper::ReadValue<uint8_t>(
buffer, currentPosition, isLittleEndian));
// skip over operator name (transform type) string
currentPosition += typeLength;

// skip over pre-data type (1) and dimensionsSize (1)
currentPosition += 2;

const uint16_t dimensionsLength = helper::ReadValue<uint16_t>(
buffer, currentPosition, isLittleEndian);
// skip over dimensions
currentPosition += dimensionsLength;

const size_t metadataLength =
static_cast<size_t>(helper::ReadValue<uint16_t>(
buffer, currentPosition, isLittleEndian));
// skip over operator metadata
currentPosition += metadataLength;

break;
}
default:
{
throw std::invalid_argument(
Expand Down

0 comments on commit 15b8642

Please sign in to comment.