Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repo-config): if ornikar-lint-staged missing run yarn [no issue] #934

Merged

Conversation

christophehurpeau
Copy link
Contributor

Context

Fix this error:

Usage Error: Couldn't find a script named "ornikar-lint-staged".

when commiting.

@christophehurpeau christophehurpeau requested a review from a team as a code owner July 13, 2023 09:35
@reviewflow
Copy link

reviewflow bot commented Jul 13, 2023

Progress

☑️ Step 1: ✏️ Write code
☑️ Step 2: 💚 Checks
☑️ Step 3: 👌 Code Review
☑️ Step 4: 🚦 Merge Pull Request

Options:

  • 🔜 automerge: Automatically merge when this PR is ready and has no failed statuses. When the repository requires branches to be up to date before merging, it merges default branch, with a queue per repo to prevent multiple merges when several PRs are ready. A fail job prevents the merge.
  • 🚦 skip-ci: Add [skip ci] on merge commit when merge is done with autoMerge.

Actions:

  • 🐛 Force updating reviewflow checks for this PR. Use this to try to fix reviewflow checks that are still missing/pending, which might happen if webhook failed or something bad happened when reviewflow tried to send the status check to github.
  • 🔄 update branch: Merge base branch in this PR's branch. Only works if merging is possible without conflicts.

@reviewflow reviewflow bot added the 🔜 automerge Synced by reviewflow for merge/automerge label Jul 13, 2023
@reviewflow reviewflow bot enabled auto-merge (squash) July 13, 2023 09:38
Copy link

@Djeg Djeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'immagine qu'il faut mettre à jour nos version de @ornikar/repo-config ?

@christophehurpeau
Copy link
Contributor Author

christophehurpeau commented Jul 13, 2023

J'immagine qu'il faut mettre à jour nos version de @ornikar/repo-config ?

oui renovate ouvrira les PRs et les membres du working group fondations les mergeront dans les repos ;)

@reviewflow reviewflow bot merged commit d68c10a into main Jul 13, 2023
2 checks passed
@reviewflow reviewflow bot deleted the fix/repo-config/if-ornikar-lint-staged-missing-run-yarn branch July 13, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔜 automerge Synced by reviewflow for merge/automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants