fix: storybook mocks should be in testSetupAfterEnv to make sure test…

…ing-library is cleanup properly
ornikar · Sep 13, 2023 · af1152c · af1152c
1 parent a8d8a63
commit af1152c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/@ornikar/jest-config-react-native/__mocks__/@storybook/react-native.jsx b/@ornikar/jest-config-react-native/__mocks__/@storybook/react-native.jsx
@@ -2,6 +2,12 @@
 
 'use strict';
 
+if (!global.afterAll) {
+  throw new Error(
+    'Missing afterAll global in mock @storybook/react-native. Please check your jest test-setup and make sure you use testSetupAfterEnv.',
+  );
+}
+
 const decorateStory = (storyFn, decorators) =>
   // eslint-disable-next-line unicorn/no-array-reduce
   decorators.reduce(
@@ -79,7 +85,6 @@ exports.storiesOf = (groupName) => {
           const rtlApi = render(story(context), { wrapper: WrappingComponent });
           if (waitForExpectation) await waitFor(() => waitForExpectation(rtlApi, expect, { parameters }));
           expect(rtlApi.toJSON()).toMatchSnapshot();
-          rtlApi.unmount();
         });
       });
 

diff --git a/@ornikar/jest-config-react/__mocks__/@storybook/react.js b/@ornikar/jest-config-react/__mocks__/@storybook/react.js
@@ -2,6 +2,12 @@
 
 'use strict';
 
+if (!global.afterAll) {
+  throw new Error(
+    'Missing afterAll global in mock @storybook/react. Please check your jest test-setup and make sure you use testSetupAfterEnv.',
+  );
+}
+
 const decorateStory = (storyFn, decorators) =>
   // eslint-disable-next-line unicorn/no-array-reduce
   decorators.reduce(
@@ -76,12 +82,11 @@ exports.storiesOf = (groupName) => {
             : ({ children }) => decorateStory(() => children, [...localDecorators, ...globalDecorators])(context);
 
           const rtlApi = render(story(context), { wrapper: wrappingComponent });
-          const { unmount, asFragment } = rtlApi;
+          const { asFragment } = rtlApi;
           if (waitForExpectation) {
             await waitFor(() => waitForExpectation(rtlApi, expect, { parameters }));
           }
           expect(asFragment()).toMatchSnapshot();
-          unmount();
         });
       });