Remove Dead Conditional from RoutingTable (elastic#56870)

`delta` is always positive here.
original-brownbear · May 18, 2020 · e2d5682 · e2d5682
1 parent f296c08
commit e2d5682
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/server/src/main/java/org/elasticsearch/cluster/routing/RoutingTable.java b/server/src/main/java/org/elasticsearch/cluster/routing/RoutingTable.java
@@ -477,13 +477,8 @@ public Builder updateNumberOfReplicas(final int numberOfReplicas, final String[]
                         builder.addReplica();
                     }
                 } else if (currentNumberOfReplicas > numberOfReplicas) {
-                    int delta = currentNumberOfReplicas - numberOfReplicas;
-                    if (delta <= 0) {
-                        // ignore, can't remove below the current one...
-                    } else {
-                        for (int i = 0; i < delta; i++) {
-                            builder.removeReplica();
-                        }
+                    for (int i = 0; i < (currentNumberOfReplicas - numberOfReplicas); i++) {
+                        builder.removeReplica();
                     }
                 }
                 indicesRouting.put(index, builder.build());