refactor: check for capitalization for specs argument

src/cli/add.rs

@@ -56,7 +56,7 @@ pub struct Args {
     /// - `pixi add --pypi boto3`
     /// - `pixi add --pypi "boto3==version"
     ///
-    #[arg(required = true)]
+    #[arg(required = true, value_parser = Args::parse_specs)]
     pub specs: Vec<String>,
 
     /// The path to 'pixi.toml'
@@ -88,6 +88,21 @@ pub struct Args {
     pub platform: Vec<Platform>,
 }
 
+impl Args {
+    /// Custom string parser for the dependencies.
+    ///
+    /// Disallows strings with non-lowercase characters.
+    fn parse_specs(specs: &str) -> Result<String, String> {
+        if specs.chars().any(|v| !v.is_lowercase()) {
+            Err(String::from(
+                "please avoid using capitalized dependency names",
+            ))
+        } else {
+            Ok(specs.to_string())
+        }
+    }
+}
+
 impl DependencyType {
     pub fn from_args(args: &Args) -> Self {
         if args.pypi {

src/project/manifest/mod.rs

@@ -355,14 +355,6 @@ impl Manifest {
             miette::bail!("pixi does not support wildcard dependencies")
         };
 
-        // Check for duplicates.
-        if dependency_table.contains_key(name.as_source()) {
-            return Err(miette::miette!(
-                "{} is already added.",
-                console::style(name.as_normalized()).bold(),
-            ));
-        }
-
         // Store (or replace) in the document
         dependency_table.insert(name.as_source(), Item::Value(spec.to_string().into()));
 
@@ -392,14 +384,6 @@ impl Manifest {
             consts::PYPI_DEPENDENCIES,
         )?;
 
-        // Check for duplicates.
-        if dependency_table.contains_key(name.as_str()) {
-            return Err(miette::miette!(
-                "{} is already added.",
-                console::style(name.as_source_str()).bold(),
-            ));
-        }
-
         // Add the pypi dependency to the table
         dependency_table.insert(name.as_str(), (*requirement).clone().into());