Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(args): add color to the help text #897

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Conversation

joshka
Copy link
Contributor

@joshka joshka commented Sep 30, 2024

Description

Color

Motivation and Context

Because pretty

How Has This Been Tested?

cargo run -- --help

Screenshots / Logs (if applicable)

image

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@joshka joshka requested a review from orhun as a code owner September 30, 2024 17:25
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.04%. Comparing base (bfe9beb) to head (8efcc1b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #897   +/-   ##
=======================================
  Coverage   40.04%   40.04%           
=======================================
  Files          21       21           
  Lines        1671     1671           
=======================================
  Hits          669      669           
  Misses       1002     1002           
Flag Coverage Δ
unit-tests 40.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orhun
Copy link
Owner

orhun commented Sep 30, 2024

Nice, it was something that I needed :)

Btw how about orange-ish colors? (maybe yellow if true color isn't possible) - for aligning it a bit closer to the logo colors?

@joshka
Copy link
Contributor Author

joshka commented Sep 30, 2024

image

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, thanks <3

@orhun orhun changed the title feat: add color to the help text feat(args): add color to the help text Oct 1, 2024
@orhun orhun merged commit f423484 into orhun:main Oct 1, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants