fix(command): add missing environment variables for Windows #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #532 +/- ##
=======================================
Coverage 41.14% 41.14%
=======================================
Files 15 15
Lines 1038 1038
=======================================
Hits 427 427
Misses 611 611
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
orhun
changed the title
|
Congrats on merging your first pull request! ⛰️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #531 where the environment variables were not being passed to cmd on Windows.
Motivation and Context
It breaks some of the functionality of being able to run custom shell commands in the preprocessor.
How Has This Been Tested?
I've tested to verify that when using the COMMIT_SHA environment variable in the traditional cmd fashion
%COMMIT_SHA%that it is now properly available to shell commands.Tested on Windows 11.
Screenshots / Logs (if applicable)
Types of Changes
Checklist: