Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(github): make less GitHub API calls #431

Closed
wants to merge 1 commit into from

Conversation

orhun
Copy link
Owner

@orhun orhun commented Jan 3, 2024

Description

This PR aims to improve the GitHub integration by sending less requests to the REST API. For that, I used the additional date parameters since and until to scope the request to a specific time frame.

However, this means that you won't be able to use the is_first_time field on the contributor since it requires the whole history to find out if the user has contributed before.

Motivation and Context

See #422

How Has This Been Tested?

Not tested yet.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@orhun orhun mentioned this pull request Jan 3, 2024
@orhun orhun marked this pull request as draft January 22, 2024 21:03
@orhun
Copy link
Owner Author

orhun commented Apr 20, 2024

closing for now, I might come back to this in the future if this becomes a bigger issue

@orhun orhun closed this Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant