-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): add ignore_tags
option
#40
Conversation
Resolves (#36) Signed-off-by: Kenji Miyake <[email protected]>
Signed-off-by: Kenji Miyake <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM! I just have a question and a few minor requests.
Absolutely liked this approach. I think we can leave it as is, just one suggestion: maybe rename the folder as About the unit tests, I think I can work on that after merging the PR. |
Signed-off-by: Kenji Miyake <[email protected]>
Signed-off-by: Kenji Miyake <[email protected]>
Signed-off-by: Kenji Miyake <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat implementation. Thank you!
ignore_tags
option
Resolves (#36)
Description
As discussed in #36, added
ignore_tags
option.Motivation and Context
Sometimes users want to carry over commits instead of dropping them as
skip_tags
option does.How Has This Been Tested?
Just tested in my local environment.
Although I tried to add tests in
changelog.rs
andintegration_tests.rs
, I thought it's impossible to testignore_tags
there.I'd like to discuss in this PR a way to add automated tests.
Screenshots / Output (if appropriate):
Types of changes
Checklist: