Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(changelog, config)!: replace --date-order by --topo-order #129

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

orhun
Copy link
Owner

@orhun orhun commented Dec 16, 2022

Description

Remove --date-order flag and add --topo-order.

Motivation and Context

See #126

How Has This Been Tested?

Unit tests + fixtures.

Screenshots / Output (if appropriate):

-

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2022

Codecov Report

Base: 46.20% // Head: 46.39% // Increases project coverage by +0.20% 🎉

Coverage data is based on head (db9eb75) compared to base (b4fa248).
Patch coverage: 23.08% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   46.20%   46.39%   +0.20%     
==========================================
  Files          12       12              
  Lines         526      526              
==========================================
+ Hits          243      244       +1     
+ Misses        283      282       -1     
Flag Coverage Δ
unit-tests 46.39% <23.08%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
git-cliff-core/src/config.rs 38.47% <ø> (ø)
git-cliff/src/bin/completions.rs 0.00% <0.00%> (ø)
git-cliff/src/bin/mangen.rs 0.00% <0.00%> (ø)
git-cliff/src/lib.rs 0.00% <0.00%> (ø)
git-cliff/src/changelog.rs 53.47% <66.67%> (ø)
git-cliff-core/src/repo.rs 52.84% <100.00%> (+1.89%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@orhun orhun force-pushed the feat/make_date_order_default branch from 5c0b134 to db9eb75 Compare December 16, 2022 17:12
@orhun orhun force-pushed the feat/make_date_order_default branch from db9eb75 to ce7d44f Compare December 16, 2022 17:29
@orhun orhun merged commit 77731ec into main Dec 16, 2022
carstencodes added a commit to carstencodes/pdm-bump that referenced this pull request Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants