Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow minimal settings to build on defaults #45

Closed
alerque opened this issue Jan 6, 2022 · 2 comments
Closed

Allow minimal settings to build on defaults #45

alerque opened this issue Jan 6, 2022 · 2 comments
Assignees
@orhun
Labels
feature/request New feature or request

Comments

@alerque
Copy link
Contributor

alerque commented Jan 6, 2022

The current config file system seems to require all required keys to be present. I am more comfortable with (and most programs support) only setting the values that I want to be different than the defaults. It would be nice if this was possible.
@alerque alerque added the feature/request New feature or request label Jan 6, 2022
@alerque alerque mentioned this issue Jan 6, 2022
Closed
orhun added a commit that referenced this issue Jan 16, 2022
@orhun
feat(config): make the git section optional (#45)
8202e37
orhun added a commit that referenced this issue Jan 16, 2022
@orhun
feat(config): make the changelog section optional (#45)
e02ae0b
@orhun
Copy link
Owner

orhun commented Jan 16, 2022

Good point 👍🏼

I pushed 8202e37 and e02ae0b thus the following config is totally valid now:

meaning that you can set the values that you want to be different from the defaults.

I will be updating README.md to mention the default values for optional configuration entries soon.

Feel free to try it out and let me know if this solves the issue 🐻

@alerque
Copy link
Contributor Author

alerque commented Jan 24, 2022

Hurray! I missed this notification but will check it out.

@orhun orhun mentioned this issue Feb 6, 2022
Merged
10 tasks
@orhun orhun closed this as completed Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orhun orhun

Labels
feature/request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alerque @orhun