refactor(error): use custom error message for GroupError

orhun · Jun 20, 2021 · 1be66ee · 1be66ee
1 parent 40a9562
commit 1be66ee
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/git-cliff-core/src/commit.rs b/git-cliff-core/src/commit.rs
@@ -96,15 +96,19 @@ impl Commit<'_> {
 						self.group = parser.group.as_ref().cloned();
 						return Ok(self);
 					} else {
-						return Err(AppError::GroupError);
+						return Err(AppError::GroupError(String::from(
+							"Skipping commit",
+						)));
 					}
 				}
 			}
 		}
 		if !filter {
 			Ok(self)
 		} else {
-			Err(AppError::GroupError)
+			Err(AppError::GroupError(String::from(
+				"Commit does not belong to any group",
+			)))
 		}
 	}
 }

diff --git a/git-cliff-core/src/error.rs b/git-cliff-core/src/error.rs
@@ -16,9 +16,9 @@ pub enum Error {
 	/// error.
 	#[error("Cannot parse the commit: `{0}`")]
 	ParseError(#[from] git_conventional::Error),
-	/// When commit's not belong to any group we throw this error.
-	#[error("Commit does not belong to any group")]
-	GroupError,
+	/// Error that may occur while grouping commits.
+	#[error("Grouping error: `{0}`")]
+	GroupError(String),
 	/// Error that may occur while template operations such as parse and render.
 	#[error("Template error: `{0}`")]
 	TemplateError(#[from] tera::Error),