Parse notebook properties and allow linking to notebooks

[amberin]

Happy holidays to all org-roam users. :)

I am working on some tests, but I want to get feedback on this as early as possible, so I'll probably add those in a separate PR.

[credmp]

Great! I use org-roam extensively and would like to test as well. Is there an APK I can test?

[amberin]

Great! I use org-roam extensively and would like to test as well. Is there an APK I can test?

Soon. I need to correct a few things, but some real testing would be great. I'll ping you!

[amberin]

@credmp F-droid and Play Store test APKs can be downloaded from the bottom of this page: https://github.com/orgzly-revived/orgzly-android-revived/actions/runs/12510540561

[credmp]

@credmp F-droid and Play Store test APKs can be downloaded from the bottom of this page: https://github.com/orgzly-revived/orgzly-android-revived/actions/runs/12510540561

Thanks! Initial comment, on a store with existing notebooks the app instantly closes. Removed the data and did a clean install, it opens then. Will report back when I have my existing repo hooked up again.

[amberin]

on a store with existing notebooks the app instantly closes. Removed the data and did a clean install, it opens then. Will report back when I have my existing repo hooked up again.

@credmp Sounds like potentially an issue with the database migration script. Big thanks for reporting -- I'll do some manual testing as well.

[credmp]

After reloading my notebooks from scratch, the id links are working beautifully! I will continue testing various scenarios, but so far it works as intended.

Would be good to be able to create new IDs in node editing screen.

Attachment links seem to be fixed in the other pull request.

[amberin]

I found the problem in the DB migration script. Upgrades seem to work well now. I fixed the main commit and force-pushed.

[amberin]

Would be good to be able to create new IDs in node editing screen.

@credmp It seems to me like it would be nice to aim for #441: an option toggle to add the "ID" property with a UUID value to all new notes created by Orgzly. This should be pretty easy to implement. The auto-complete feature for linking to existing notes discussed in #441 also sounds really nice, but I suspect it's slightly more work.

[amberin]

New test APK available here. Install on your own risk -- not guaranteed to play nice with future app updates.

[credmp]

Also tested heading based ids, works very nicely! Great work!

Would be good to be able to create new IDs in node editing screen.

@credmp It seems to me like it would be nice to aim for #441: an option toggle to add the "ID" property with a UUID value to all new notes created by Orgzly. This should be pretty easy to implement. The auto-complete feature for linking to existing notes discussed in #441 also sounds really nice, but I suspect it's slightly more work.

[will x-post this to the issue]
Automatically creating on the book level is a good idea (and roam compatible). I would not auto-create on a heading, as this means that every heading will show up in roam's search.

[amberin]

[will x-post this to the issue] Automatically creating on the book level is a good idea (and roam compatible). I would not auto-create on a heading, as this means that every heading will show up in roam's search.

Thanks, that's very useful input, as I don't use roam myself.

[credmp]

Additional not on linking to headings: it currently follows the link to the edit screen of the heading, perhaps it is better to jump to the heading in the reading screen to see it in context?

[amberin]

Additional not on linking to headings: it currently follows the link to the edit screen of the heading, perhaps it is better to jump to the heading in the reading screen to see it in context?

That makes a lot of sense, but this behavior was not touched here, so it should be a separate enhancement. If you'd care to create an issue, that would be great!

[amberin]

Docs update PR: orgzly-revived/documentation#7

[alexanderkunz]

Tested with both notebooks and heading, did not find any issues. Initially I was surprised by the edit screen for the heading link as well. However, the notebook view can be easily accessed from there, so it is not a problem. I agree opening it in the notebook view as for notebook links could be an additional option in the future. 👍

[decadent]

Additional not on linking to headings: it currently follows the link to the edit screen of the heading, perhaps it is better to jump to the heading in the reading screen to see it in context?

If I understand the problem right, there's already an issue for this in #399. But apparently it's solved by the 'link target' setting in the options, which is named kinda tersely and unintuitively.

[decadent]

So this linking to notebooks is different from file: links? Because those already work, just fyi.

Regarding creating an ID for a heading — perhaps this should be implemented like in Org: an item in the three-dot menu on the edit screen and maybe also in the swipe overlay, that both adds the ID and copies the link to the clipboard, preferably in full Org syntax. (Still idk if Org has a function that does all this together, but I hacked one for myself by calling org-id-get-create then org-store-link.) I don't use the beta, so might be that this is how it works already.

[amberin]

So this linking to notebooks is different from file: links? Because those already work, just fyi.

Yes, I should have named it "allow linking to notes by ID".

Regarding creating an ID for a heading — perhaps this should be implemented like in Org: an item in the three-dot menu on the edit screen and maybe also in the swipe overlay, that both adds the ID and copies the link to the clipboard, preferably in full Org syntax. (Still idk if Org has a function that does all this together, but I hacked one for myself by calling org-id-get-create then org-store-link.) I don't use the beta, so might be that this is how it works already.

So far there is only (in 1.8.36) the toggle to add IDs to all new notes. But check #441 for some more discussed ideas. It's partly what you describe, but the clipboard thing sounds good to me, unless we risk replacing clipboard contents in an unexpected way.