Extend ShareActivity to wrap captured link into org link if possible #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! |
amberin
approved these changes
Sep 15, 2024
amberin
requested review from
xiaoruoruo,
alensiljak,
stefan2904,
NatKarmios and
cbkerr
stefan2904
reviewed
Sep 19, 2024
app/src/main/java/com/orgzly/android/ui/share/ShareActivity.java
Outdated
Show resolved
Hide resolved
amberin
requested changes
Jan 8, 2025
There was a problem hiding this comment.
@lingnand I have made a PR to your branch suggesting a different way to recognize URLs: lingnand#1
Use java.net.URL to recognize URLs
|
@lingnand We should switch to java.net.URI, as you suggested elsewhere (and catch URISyntaxException instead). |
After discussion with @lingnand: >>> Good idea to use proper class to parse. Can we use java.net.URI instead? A lot of org links are not web URL but URI e.g. file:a/b/c >> Sure. I was thinking that one may not want to handle all types of URIs like this. But if you can imagine a use case, then let's do it. > I use an Email app that generate links to emails, which fall into this category (basically, Android app links are this format)
Use URI class, not URL
amberin
approved these changes
Jan 13, 2025
|
Thank you for your first contribution, @lingnand! Edit: Sorry, I mean second contribution! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks at the incoming intent data and wraps a link with title information into an org link.