Log sync times to "major events" log #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To facilitate installing and testing multiple branches of the app in parallel.
This enables easier benchmarking of sync times when testing changes to the sync logic. I am currently looking at alternative sync workflows for Git repos, and it's hard to compare sync times just by looking. Why did I remove the argument to AppLogsRepository.getFlow()? Because I believe it was a case of over-engineering. There is no way to specify which type of logs you want to view, and until there is, the only reasonable behavior is to show all logs.
|
I don't actually intend to merge to the release branch - I just pointed to that now, since it is the latest code. When v1.8.15 has been released, this PR will be pointed to master. |
alensiljak
reviewed
Feb 2, 2024
alensiljak
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables easier benchmarking of sync times when testing changes to
the sync logic. I am currently looking at alternative sync workflows for
Git repos, and it's hard to compare sync times just by looking.
Why did I remove the argument to AppLogsRepository.getFlow()? Because I
believe it was a case of over-engineering. There is no way to specify
which type of logs you want to view, and until there is, the only
reasonable behavior is to show all logs.
I have tested this code on my Pixel 5.