Removed forced Light theme for splash screen during cold start #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves issue orgzly-revived#139. Android 12 has a new "splash screen" behaviour which uses the application background theming (from Manifest). The theme was forced to Light theme and it blinded a user with a bright white background, even when dark theme was set in the app, and dark theme was configured system-wide. By simply removing background configuration in the application Manifest, android 12 now uses the system-wide proper color according to the configured system theme. There seems to be no side effect on previous android versions (which did not even show this slash screen after all).
|
Looks great! |
|
Just checking, is this still a draft? |
|
Sorry, I was unsure as how to proceed. I removed the draft status; I believe it should be safe to merge. |
amberin
approved these changes
Feb 1, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #139.
Android 12 has a new "splash screen" behaviour which uses the application background theming (from Manifest).
The theme was forced to Light theme and it blinded a user with a bright white background, even when dark theme was set in the app, and dark theme was configured system-wide.
By simply removing background configuration in the application Manifest, android 12 now uses the system-wide proper color according to the configured system theme.
There seems to be no side effect on previous android versions (which did not even show this slash screen after all).